Commit e0ab6427 authored by cmosh's avatar cmosh

final edits

parent 882e6b7b
...@@ -497,9 +497,6 @@ cmd_review() { ...@@ -497,9 +497,6 @@ cmd_review() {
OWNER=$(basename $(echo $URL_WITH_OWNER | tr ":" /)) OWNER=$(basename $(echo $URL_WITH_OWNER | tr ":" /))
DEVELOPMENT_BRANCH=$(git config --get gitflow.branch.develop) DEVELOPMENT_BRANCH=$(git config --get gitflow.branch.develop)
echo $REPO $OWNER
echo $BRANCH
if [ -f ./.git/.gitflow/.github_token ]; if [ -f ./.git/.gitflow/.github_token ];
then then
...@@ -518,12 +515,13 @@ cmd_review() { ...@@ -518,12 +515,13 @@ cmd_review() {
}' \ }' \
"https://api.github.com/repos/$OWNER/$REPO/pulls") "https://api.github.com/repos/$OWNER/$REPO/pulls")
if [ "$GITHUB_REQUEST" -gt 300 ] echo "Pull request created on github please inform the code reviewer by mentioning them in the comments"
then
echo "Failed to create pull request" # if [ "$GITHUB_REQUEST" -gt 300 ]
else # then
echo "Pull request created succesfully" # echo "Failed to create pull request"
fi # else
# fi
fi fi
...@@ -541,14 +539,16 @@ cmd_review() { ...@@ -541,14 +539,16 @@ cmd_review() {
"body":"'"$USER_NAME"' is asking for code review. Total time taken:'"$FINALTIME"' expected time was '"$TIME_EXPECTED"' hour(s), Time spent on breaks was '"$TOTAL_TIME_OFF"' -- message by gitflow" "body":"'"$USER_NAME"' is asking for code review. Total time taken:'"$FINALTIME"' expected time was '"$TIME_EXPECTED"' hour(s), Time spent on breaks was '"$TOTAL_TIME_OFF"' -- message by gitflow"
}' "https://gitlab.com/api/v3/projects/$OWNER%2F$REPO/merge_requests") }' "https://gitlab.com/api/v3/projects/$OWNER%2F$REPO/merge_requests")
echo "Pull request created on gitlab please inform the code reviewer by mentioning them in the comments"
if [ "$GITLAB_REQUEST" -gt 300 ]
then # if [ "$GITLAB_REQUEST" -gt 300 ]
echo "Failed to create merge request" # then
else # echo "Failed to create merge request"
echo "Merge request created succesfully" # else
fi # echo "Merge request created succesfully"
fi # fi
# fi
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment